Skip to content

feat(iOS): Enable synchronous header config shadow state updates by default#3932

Merged
kmichalikk merged 3 commits intomainfrom
@kmichalikk/enable-synchronous-header-config-updates
Apr 28, 2026
Merged

feat(iOS): Enable synchronous header config shadow state updates by default#3932
kmichalikk merged 3 commits intomainfrom
@kmichalikk/enable-synchronous-header-config-updates

Conversation

@kmichalikk
Copy link
Copy Markdown
Contributor

Description

This PR changes the default value for synchronousHeaderConfigUpdatesEnabled flag to true.

Changes

Updated flag default, native and JS defaults

Before & after - visual documentation

N/A

Test plan

See #3282

Checklist

  • Included code example that can be used to test this change.
  • For visual changes, included screenshots / GIFs / recordings documenting the change.
  • For API changes, updated relevant public types.
  • Ensured that CI passes

@kmichalikk kmichalikk self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR flips the default for the experimental synchronousHeaderConfigUpdatesEnabled feature flag to true, enabling synchronous shadow state updates for stack header config on iOS by default (aligning JS, codegen defaults, and the native initial state).

Changes:

  • Set the JS feature flag default synchronousHeaderConfigUpdatesEnabled to true.
  • Update the Fabric codegen default for synchronousShadowStateUpdatesEnabled on RNSScreenStackHeaderConfig to true.
  • Initialize the iOS native header config’s _synchronousShadowStateUpdatesEnabled to YES by default, and update the Fabric example flag to true.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/flags.ts Changes the JS default for synchronousHeaderConfigUpdatesEnabled to true.
src/fabric/ScreenStackHeaderConfigNativeComponent.ts Updates the codegen default for synchronousShadowStateUpdatesEnabled to true.
ios/RNSScreenStackHeaderConfig.mm Sets the native initial default _synchronousShadowStateUpdatesEnabled to YES.
FabricExample/App.tsx Enables the flag in the Fabric example configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ios/RNSScreenStackHeaderConfig.mm Outdated
@kmichalikk kmichalikk merged commit 4b7072a into main Apr 28, 2026
8 checks passed
@kmichalikk kmichalikk deleted the @kmichalikk/enable-synchronous-header-config-updates branch April 28, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants